better sampling args handling for vf-eval and grpo trainer #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in the current
vf-evalimplementation, when using a vLLM backend, passing sampling parameters liketop_kandmin_pis not that straightforward. i have to pass a nested JSON to get it to work--sampling-args '{"top_p": 0.95, "extra_body": {"top_k": 20, "min_p": 0.05}}'sampling_utilsto help with serialization of vLLM-specific sampling parametersvf-evalCLI support with dedicated sampling flags similar toGRPOTrainer, while preserving JSON overridesGRPOTrainerto create sampling payloads using sampling utilsType of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
The changes are made for easier support of sampling parameters such as
top_kandmin_pin vf-eval script when using vLLM backend. OpenAI backend does not support these arguments and will drop them. If using some other backend which supports these arguments but does not follow the vLLM format, they should still be passed using --sampling-args.