Make example_id unique in EnvGroup #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prime-rl depend on
example_idbeing unique across the entire env dataset - this is currently not the case forEnvGroup.Previously, both samples have ID 0
[{'question': 'a', 'completion': 'A', 'example_id': 0, 'prompt': [{'content': 'a', 'role': 'user'}], 'task': 'env_0'}, {'question': 'a', 'completion': 'A', 'example_id': 0, 'prompt': [{'content': 'a', 'role': 'user'}], 'task': 'env_1'}]Now, they have IDs 0 and 1, as expected
[{'question': 'a', 'completion': 'A', 'prompt': [{'content': 'a', 'role': 'user'}], 'task': 'env_0', 'example_id': 0}, {'question': 'a', 'completion': 'A', 'prompt': [{'content': 'a', 'role': 'user'}], 'task': 'env_1', 'example_id': 1}]Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes