Skip to content

Conversation

@agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Nov 5, 2024

Issue & Reproduction Steps

Steps to Reproduce:

  • Create a new screen
  • Use the Select List component in the screen
  • Configure the aria-label in Advanced property

Current Behavior:
The same aria-label is repeated for each option in the Select List. This is causing that the screen readers for disabilities reads the label question every time. This behavior is unexpected for the customer.

Expected Behavior:

ProcessMaker should allow configure the aria-label for each option in the aria-label property. One for the label and one for each option in the Select List component for the screen readers.

Solution

  • Added area label option for checkbox renderAs mode, for provide data, request data, data connectors and collections.

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:vue-form-elements:task/FOUR-19875

@agustinbusso
Copy link
Contributor Author

Related PRs:
Screen Builder
Vue Form Elements
Core

@boliviacoca boliviacoca added 4.13.0 and removed 4.12.0 labels Jan 8, 2025
@agustinbusso agustinbusso changed the base branch from release-2024-fall to release-2025-winter January 10, 2025 18:04
@agustinbusso
Copy link
Contributor Author

There are some failing test, and seems that are not related to the changes in this PR:

SAMLLogout (ProcessMaker\Package\Auth\Tests\Feature\SAMLLogout)
 ✘ Logout saml
   │
   │ Failed asserting that two strings are equal.
   │ --- Expected
   │ +++ Actual
   │ @@ @@
   │ -'https://localhost/login'
   │ +'https://localhost/requests'
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:311
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:178
   │ /opt/packages/package-auth/tests/Feature/Auth/SAMLLogoutTest.php:106
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176

Formula (Tests\PackageDecisionEngine\Feature\Formula)
 ✘ Decision table with correct values
   │
   │ Error: Call to undefined method Tests\PackageDecisionEngine\Feature\FormulaTest::createProcessFromJSON()
   │
   │ /opt/packages/package-decision-engine/tests/feature/FormulaTest.php:20
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │

 ✘ Decision table with incorrect values
   │
   │ Error: Call to undefined method Tests\PackageDecisionEngine\Feature\FormulaTest::createProcessFromJSON()
   │
   │ /opt/packages/package-decision-engine/tests/feature/FormulaTest.php:55
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │

 ✘ Decision table without values
   │
   │ Error: Call to undefined method Tests\PackageDecisionEngine\Feature\FormulaTest::createProcessFromJSON()
   │
   │ /opt/packages/package-decision-engine/tests/feature/FormulaTest.php:90
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176

CC @ryancooley

@ryancooley ryancooley merged commit 54d4912 into release-2025-winter Jan 23, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants