Skip to content

Conversation

@CarliPinell
Copy link
Contributor

Solution

  • All settings for Collections in Recod List Control will cleaned when option "Variable" is selected.

How to Test

  • Login PM
  • Create a screen
  • Create a Record list
    select collection option in the Configuration > Source of Record List
    Select a collection
    Select any option in the Data Selection and select a column
  • Press preview button (it works correctly)
  • Press Design button
  • Edit the Record list
    select Variable option in the Configuration > Source of Record List
  • Add custom header in the columns accordion
  • Press Preview button

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-20076

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cypress
Copy link

cypress bot commented Nov 12, 2024

screen-builder    Run #1674

Run Properties:  status check passed Passed #1674  •  git commit 4fa719d6eb: Bugfix/FOUR-20076: Properties are not cleaned when `Source of Record List` field...
Project screen-builder
Branch Review bugfix/FOUR-20076
Run status status check passed Passed #1674
Run duration 09m 39s
Commit git commit 4fa719d6eb: Bugfix/FOUR-20076: Properties are not cleaned when `Source of Record List` field...
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit 48e7c8a into release-2024-fall Nov 12, 2024
14 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-20076 branch November 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants