Skip to content

Conversation

@estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Nov 15, 2024

Issue & Reproduction Steps

This PR addresses an issue with the select list component in conversational screens when configured with a data connector, allowing multiple selections and using the object value type.

Multiple options were selected but only commas were printed instead of the selected values.


Steps to Reproduce:

  1. Log in.
  2. Navigate to Designer.
  3. Click on Screens.
  4. Create a Conversational Screen.
  5. Add a Select List component.
  6. Configure the select list to use a Data Connector.
  7. Enable the option Allow Multiple Selection.
  8. Set the Value Type to Object.
  9. Save the screen.
  10. Click on Preview.
  11. Select multiple options from the select list.

Current Behavior:

  • When multiple options are selected, the output only displays commas, without the selected values.
Screenshot 2024-11-14 at 9 13 22 AM

Expected Behavior:

  • The select list should display the selected values separated by commas for multiple selections.

Solution

  • This fix ensures the select list behaves as expected, aligning the display with previous versions.
  • Enable Value configuration of Data Connector

How to Test

  • Please follow the Steps to Reproduce and make sure that the Expected Behavior is met.
  • In the value configuration, you should be able to use name, data.name or leave it empty.
Screenshot 2024-11-14 at 4 01 55 PM

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cypress
Copy link

cypress bot commented Nov 15, 2024

screen-builder    Run #1696

Run Properties:  status check passed Passed #1696  •  git commit cea9602d8a: FOUR-20074: Fix Select List Display Issue for Multiple Selections with Data Conn...
Project screen-builder
Branch Review observation/FOUR-20074
Run status status check passed Passed #1696
Run duration 39m 54s
Commit git commit cea9602d8a: FOUR-20074: Fix Select List Display Issue for Multiple Selections with Data Conn...
Committer Esteban Gallego
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

@mcraeteisha mcraeteisha self-requested a review November 15, 2024 19:33
@ryancooley ryancooley merged commit 3bb4676 into release-2024-fall Nov 20, 2024
@ryancooley ryancooley deleted the observation/FOUR-20074 branch November 20, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants