Skip to content

Conversation

@CarliPinell
Copy link
Contributor

Solution

  • In Screen Builder, when some screen has Collection Record Control, and user clicks over the control, its settings does not change

How to Test

  • Login PM4
  • Go to Designer->Screens
  • Create a FORM type Screen
  • Drag Input Field and rename as "list", drag also a Submit button.
  • Drag Collection Record Control, select a collection and set {{list}} into Record Id field. Select EDIT mode.
  • Save and Publish this new Screen and Assign to some simple Process start-task-end
  • Run the process and fill the Form. Submit the process.
  • Open the previous Screen in Screen Builder and click on Collection Record Control.
  • Save and Publish.
  • Run again the process and fill the form.
  • When submit button is clicked, no errors should be displayed anda process should be completed normally.

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-21071

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cypress
Copy link

cypress bot commented Nov 26, 2024

screen-builder    Run #1697

Run Properties:  status check passed Passed #1697  •  git commit b4145c4a31: Bugfix/FOUR-21071: Collection Record Control changes saved settings when the con...
Project screen-builder
Branch Review bugfix/FOUR-21071
Run status status check passed Passed #1697
Run duration 09m 09s
Commit git commit b4145c4a31: Bugfix/FOUR-21071: Collection Record Control changes saved settings when the con...
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
image

@ryancooley ryancooley merged commit 581c3f1 into release-2024-fall Dec 2, 2024
14 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-21071 branch December 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants