Skip to content

Conversation

@fagubla
Copy link
Contributor

@fagubla fagubla commented Jan 2, 2025

Issue & Reproduction Steps

  1. Create a process: Start Event - Task - End Event.
  2. In the Task, create a screen with 2 pages. Page 1 has a Page Navigation button to take the user to the second page.
  3. Save the screen and publish the process.
  4. Start a case.
  5. Click on the Navigation Button.
  6. On the second page, zoom to 150%.

Current Behavior:
The screen returns to the first page.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@cypress
Copy link

cypress bot commented Jan 2, 2025

screen-builder    Run #1773

Run Properties:  status check passed Passed #1773  •  git commit b3816b145c: FOUR-19561: In a screen with more than one page, when I zoom more than 150% I re...
Project screen-builder
Branch Review bugfix/FOUR-19561
Run status status check passed Passed #1773
Run duration 09m 02s
Commit git commit b3816b145c: FOUR-19561: In a screen with more than one page, when I zoom more than 150% I re...
Committer Fabio Rodolfo Guachalla Blanco
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 366
View all changes introduced in this branch ↗︎

@fagubla
Copy link
Contributor Author

fagubla commented Jan 3, 2025

@caleeli all tests are green

@caleeli caleeli self-requested a review January 7, 2025 19:04
Copy link
Collaborator

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@pmPaulis pmPaulis changed the base branch from release-2024-fall to release-2025-winter January 27, 2025 18:38
@pmPaulis
Copy link
Contributor

@boliviacoca @ryancooley
The Storybook is showing this issue:

Package libasound2 is a virtual package provided by:
  liboss4-salsa-asound2 4.2-build2020-1ubuntu3
  libasound2t64 1.2.11-1build2 (= 1.2.11-1build2)

E: Package 'libasound2' has no installation candidate
Failed to install browsers
Error: Installation process exited with code: 100

This is fixed in the PR:
#1785

Regards,

@pmPaulis
Copy link
Contributor

pmPaulis commented Feb 4, 2025

@ryancooley @boliviacoca
In this PR is failing the CICD deploy-EKS, I created the following ticket
https://processmaker.atlassian.net/browse/SCO-27217
Regards,

@tokensPM
Copy link

tokensPM commented Feb 4, 2025

QA server K8S was successfully deployed https://ci-52f60887da.engk8s.processmaker.net

1 similar comment
@tokensPM
Copy link

tokensPM commented Feb 4, 2025

QA server K8S was successfully deployed https://ci-52f60887da.engk8s.processmaker.net

@pmPaulis pmPaulis changed the base branch from release-2025-winter to release-2025-spring February 26, 2025 15:13
@pmPaulis
Copy link
Contributor

Update with release-2025-spring and marked Spring Review

@pmPaulis
Copy link
Contributor

the unit test issue is not related with the changes

Filter (Tests\Filter)
 ✘ Compare data integer
   │
   │ Failed asserting that actual size 2 matches expected size 1.
   │
   │ /opt/processmaker/tests/unit/ProcessMaker/FilterTest.php:88
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │

@fagubla fagubla changed the title FOUR-19561:In a screen with more than one page, when I zoom more than 150% I return to the first page FOUR-19561: In a screen with more than one page, when I zoom more than 150% I return to the first page Feb 26, 2025
@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pmPaulis
Copy link
Contributor

checks-pass-free

@ryancooley ryancooley merged commit b8711f3 into release-2025-spring Feb 26, 2025
29 of 30 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19561 branch February 26, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants