Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometric transform implementations #7955

Draft
wants to merge 31 commits into
base: dev
Choose a base branch
from

Conversation

atbenmurray
Copy link
Contributor

Implementations for unified spatial raster / geometry operations along with unit tests. More to be added later

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Sorry, something went wrong.

KumoLiu and others added 20 commits April 12, 2024 14:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Part of Project-MONAI#7486


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Signed-off-by: Ben Murray <[email protected]>
@atbenmurray atbenmurray changed the title Geometric all Geometric transform implementations Jul 26, 2024
for more information, see https://pre-commit.ci
@vikashg
Copy link

vikashg commented Jul 31, 2024

Hello Ben,
Can you also add a jupyter-notebook with some real images and geometric points (annotations). It will be much easier for to play around with the code without breaking anything.
Thanks

@atbenmurray
Copy link
Contributor Author

Hi @vikashg. I will. As soon as I've finished my camera ready presentation I'll finish this PR. Should all be ready for thursday

@atbenmurray
Copy link
Contributor Author

Hello Ben, Can you also add a jupyter-notebook with some real images and geometric points (annotations). It will be much easier for to play around with the code without breaking anything. Thanks

Yes, I'll provide one

atbenmurray and others added 4 commits August 2, 2024 10:43
Signed-off-by: Ben Murray <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Ben Murray <[email protected]>
…y data (like Spacing)

Signed-off-by: Ben Murray <[email protected]>
Signed-off-by: Ben Murray <[email protected]>
Signed-off-by: Ben Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants