Skip to content

fix an assertion that would fire erroneously fire due to int overflow #7257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DennisOSRM merged 4 commits into from
Jan 11, 2026
Merged

fix an assertion that would fire erroneously fire due to int overflow #7257

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6df33b8
fix an assertion that would fire erroneously fire due to int overflow
woodpeck Oct 10, 2025
28fa3bc
Refactor assertions for edge sizes
TheMarex Jan 9, 2026
7d9a09e
Update contracted_edge_container.hpp
TheMarex Jan 9, 2026
984bb01
Merge branch 'master' into fix_assertion
DennisOSRM Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/contractor/contracted_edge_container.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ struct ContractedEdgeContainer
edges.insert(edges.end(), new_edges.begin(), new_end);
auto edges_size = edges.size();
auto new_edges_size = std::distance(new_edges.begin(), new_end);
BOOST_ASSERT(static_cast<int>(edges_size) >= new_edges_size);
Copy link
Member

@TheMarex TheMarex Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here is a better fix here: We want int64_t which will be equivalent to std::ptrdiff_t (the return type of std::distance). The casting to int was probably there originally because the return type of std::distance is signed.

BOOST_ASSERT(static_cast<int64_t>(edges_size) >= new_edges_size);
flags.resize(edges_size);
std::fill(flags.begin() + edges_size - new_edges_size, flags.end(), flag);

Expand Down
Loading