Fix clang-21 warnings #7303
Merged
Fix clang-21 warnings #7303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarex
force-pushed
the
Fix-clang-21-warnings
branch
from
f701bfb to
9c24cec
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes clang-21 compiler warnings by removing the virtual keyword from methods in the TableAPI class, which is marked as final. Since a final class cannot be further derived from, marking its methods as virtual is unnecessary and triggers warnings in clang-21.
Key changes:
- Removed
virtualkeyword from destructor and all member functions inTableAPI - Maintained proper formatting and alignment throughout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheMarex
force-pushed
the
Fix-clang-21-warnings
branch
from
9c24cec to
5d447c8
Compare
TheMarex
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7302: clang-21 build fails with warnings
Tasklist