Skip to content

fix(cli): #1576 fix nested greenwood type imports from breaking the build #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
thescientist13 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(cli): #1576 fix nested greenwood type imports from breaking the build #1634

thescientist13 wants to merge 1 commit into from

Conversation

@thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 24, 2026 •
edited
Loading

Related Issue

resolves #1576

Documentation

(if we can't figure this out)
ProjectEvergreen/www.greenwoodjs.dev#262

Summary of Changes

  1. Have Rollup externalize any Greenwood specific packages

See the patch here - thescientist13/greenwood-loops#2

TODO

  1. Will need to refine this to make sure it doesn't catch legitimate use cases that are actually exposed through our exports, like the router or active content client
    Screenshot 2026-01-23 at 8 49 57 PM

@thescientist13 thescientist13 added bug Something isn't working CLI alpha.3 v0.34.0 labels Jan 24, 2026
@thescientist13 thescientist13 changed the title fix(cli): #1576 fix nested greenwood type imports fix(cli): #1576 fix nested greenwood type imports Jan 24, 2026
@thescientist13 thescientist13 added the Types(cript) Requires type definition or TypeScript related work / documentation label Jan 24, 2026
@thescientist13 thescientist13 changed the title fix(cli): #1576 fix nested greenwood type imports fix(cli): #1576 fix nested greenwood type imports from breaking the build Jan 24, 2026
@thescientist13 thescientist13 added question Further information is requested invalid This doesn't seem right labels Jan 24, 2026
@thescientist13 thescientist13 marked this pull request as draft January 25, 2026 00:44
thescientist13
thescientist13 commented Jan 25, 2026
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be something we can cleanly handle, especially if this invokes running / bundling of Greenwood CLI code - #1576 (comment)

thescientist13
thescientist13 commented Jan 25, 2026
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if did want to try and solve this, I wondering if getting around the usage of URL here would bypass the issue entirely? 🤔 🤞
https://github.com/ProjectEvergreen/greenwood/blob/v0.34.0-alpha.2/packages/cli/src/lifecycles/bundle.js#L362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alpha.3 bug Something isn't working CLI invalid This doesn't seem right question Further information is requested Types(cript) Requires type definition or TypeScript related work / documentation v0.34.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

type imports within the brackets breaks the build when importing Greenwood types

2 participants

@thescientist13