Skip to content

Minor internal api cleanups to improve comments and avoid errors #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor internal api cleanups to improve comments and avoid errors #1752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/api/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ export class OpenSeaAPI {
* @param options.side The side of the order (listing or offer)
* @param options.protocol The protocol, typically seaport, to query orders for
* @param options.orderDirection The direction to sort the orders
* @param options.orderBy The field to sort the orders by
* @param options.limit The number of orders to retrieve
* @param options.maker Filter by the wallet address of the order maker
* @param options.taker Filter by wallet address of the order taker
* @param options.asset_contract_address Address of the NFT's contract
Expand All @@ -136,14 +134,13 @@ export class OpenSeaAPI {
side,
protocol = "seaport",
orderDirection = "desc",
orderBy = "created_date",
...restOptions
}: Omit<OrdersQueryOptions, "limit">): Promise<OrderV2> {
}: Omit<OrdersQueryOptions, "limit" | "orderBy">): Promise<OrderV2> {
const { orders } = await this.get<OrdersQueryResponse>(
getOrdersAPIPath(this.chain, protocol, side),
serializeOrdersQueryOptions({
limit: 1,
orderBy,
orderBy: "created_date",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

ran into this error when trying to pass "eth_price"

orderDirection,
...restOptions,
}),
Expand All @@ -161,7 +158,6 @@ export class OpenSeaAPI {
* @param options.protocol The protocol, typically seaport, to query orders for
* @param options.orderDirection The direction to sort the orders
* @param options.orderBy The field to sort the orders by
* @param options.limit The number of orders to retrieve
* @param options.maker Filter by the wallet address of the order maker
* @param options.taker Filter by wallet address of the order taker
* @param options.asset_contract_address Address of the NFT's contract
Expand Down