Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete URL; assign CRS via JSON file; code cleanup #34

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

ktyle
Copy link
Collaborator

@ktyle ktyle commented Oct 25, 2024

Addresses #33, and refreshes code

Copy link

github-actions bot commented Oct 25, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 05e3dcf
✅ Deployment Preview URL: https://ProjectPythia.github.io/HRRR-AWS-cookbook/_preview/34

@ktyle ktyle requested a review from brian-rose October 25, 2024 14:59
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. There's something funny going on with how the preview is being deployed. Not related to the PR as far as I know. I'll merge this and investigate separately.

@brian-rose brian-rose merged commit 8e35523 into ProjectPythia:main Oct 25, 2024
2 checks passed
@ktyle ktyle deleted the oct24 branch November 15, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants