-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: Symmetric Keys and Forwarding #141
Draft
wussler
wants to merge
10
commits into
main
Choose a base branch
from
Proton
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d52fc0 - Browse repository at this point
Copy the full SHA 5d52fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 719c5d3 - Browse repository at this point
Copy the full SHA 719c5d3View commit details -
openpgp: Add support for symmetric subkeys (#74)
It is sometimes useful to encrypt data under some symmetric key. While this was possible to do using passphrase-derived keys, there was no support for long-term storage of the keys that was used to encrypt the key packets. To solve this, a new type of key is introduced. This key will hold a symmetric key, and will be used for both encryption and decryption of data. Specifically, as with asymmetric keys, the actual data will be encrypted using a session key, generated ad-hoc for these data. Then, instead of using a public key to encrypt the session key, the persistent symmetric key will be used instead, to produce a, so to say, Key Encrypted Key Packet. Conversly, instead of using a private key to decrypt the session key, the same symmetric key will be used. Then, the decrypted session key can be used to decrypt the data packet, as usual. As with the case of AEAD keys, it is sometimes useful to "sign" data with a persistent, symmetric key. This key holds a symmetric key, which can be used for both signing and verifying the integrity of data. While not strictly needed, the signature process will first generate a digest of the data-to-be-signed, and then the key will be used to sign the digest, using an HMAC construction. For technical reasons, related to this implenetation of the openpgp protocol, the secret key material is also stored in the newly defined public key types. Future contributors must take note of this, and not export or serialize that key in a way that it will be publicly availabe. Since symmetric keys do not have a public and private part, there is no point serializing the internal "public key" structures. Thus, symmetric keys are skipped when serialing the public part of a keyring.
Configuration menu - View commit details
-
Copy full SHA for df3b225 - Browse repository at this point
Copy the full SHA df3b225View commit details -
Configuration menu - View commit details
-
Copy full SHA for d45f98d - Browse repository at this point
Copy the full SHA d45f98dView commit details -
Full PQC support (+33 squashed commits)
Squashed commits: Update KDF to use SHA3-256 [5ff62f7] WIP: bump to draft-ietf-openpgp-pqc-01 [3949477] Import CIRCL fork with ML-KEM and ML-DSA [5033a18] Update implementation from draft v1 to v3 - Remove v6 binding for PQC KEMs - Update KDF - Update reference comments - Rename SPHINCS+ to SLH-DSA - Rename Dilithium to ML-DSA - Rename Kyber to ML-KEM - Add vectors generated with RNP - Fix misc bugs and improve tests [c53e2e3] Add benchmarking [d832873] Add read-write tests [8254a42] Bind PQC packets to v6 [21f33d3] Change testdata for Kyber keys and prepare for v6 PKESK [fa295de] Change domain separation [c5bc3c1] Add SPHINCS+ signature support [603ced6] Add references and clean code [9b26049] Prefer PQ keys [6e5ec9c] Add hybrid Kyber + ECDH, Dilithium + EC/EdDSA support [4d1ed63] Adapt PQC to the v2 API [3661202] Remove sphincs PQC logic [2a463c8] Remove PQC algorithms with brainpool and nist curves [29ee4e6] Update links to PQC draft-rfc [a75af1c] feat: Update to latest circle version [587aac2] feat: Derive ML-DSA keys from seed [ec6b930] feat: Fallback to AES256 if all recipients are PQ [1c0666f] refactor: Improve mlkem readability [5d56595] feat: Integrate review feedback [cd836af] feat: Update circl to v1.5.0 [902b302] chore: Add kmac back [cee95ab] feat: Update to new kmac key combiner in kem [086f153] Disallow v4 PQC KEM keys [2440667] feat: Add seed format for ML-KEM [3052ac2] feat: Integrate ML-DSA seed fromat [c00cd40] feat: Update kem key combinder to latest version [9677cf4] feat: Avoid panic on key size in kmac [1bd89db] fix: Kem key combiner should use the kmac correct key [28848f7] feat: Force SHA3 for ML-DSA [6faefab] feat: Enforce SHA3 in clearsing API in ML-DSA [5de74a1] refactor: Add HandleSpecificHash method on PublicKeyAlgorithm
Configuration menu - View commit details
-
Copy full SHA for 38933df - Browse repository at this point
Copy the full SHA 38933dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99debaa - Browse repository at this point
Copy the full SHA 99debaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0534312 - Browse repository at this point
Copy the full SHA 0534312View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a59df2 - Browse repository at this point
Copy the full SHA 8a59df2View commit details -
Revert "[v2] Use AEAD if all public keys support it"
This reverts commit 63e3da1.
Configuration menu - View commit details
-
Copy full SHA for 8c808a9 - Browse repository at this point
Copy the full SHA 8c808a9View commit details
Commits on Nov 14, 2024
-
Revert "Update to draft-ietf-openpgp-persistent-symmetric-keys-00"
This reverts commit 99debaa.
Configuration menu - View commit details
-
Copy full SHA for eebabee - Browse repository at this point
Copy the full SHA eebabeeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.