Skip to content

fix(Bouncer): fix bounds checking in OnPlayerPortalTeleport (#3127) #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: general-devel
Choose a base branch
from
Open

fix(Bouncer): fix bounds checking in OnPlayerPortalTeleport (#3127) #3128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TShockAPI/Bouncer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2535,8 +2535,8 @@ internal void OnPlayerPortalTeleport(object sender, GetDataHandlers.TeleportThro
}

//Generic bounds checking, though I'm not sure if anyone would willingly hack themselves outside the map?
if (args.NewPosition.X > Main.maxTilesX || args.NewPosition.X < 0
|| args.NewPosition.Y > Main.maxTilesY || args.NewPosition.Y < 0)
if (args.NewPosition.X > Main.maxTilesX *16 || args.NewPosition.X < 0
|| args.NewPosition.Y > Main.maxTilesY *16 || args.NewPosition.Y < 0)
{
TShock.Log.ConsoleDebug(GetString("Bouncer / OnPlayerPortalTeleport rejected teleport out of bounds from {0}", args.Player.Name));
args.Handled = true;
Expand Down
Loading