chore: apply position moves + drop dead Elo-category code#112
Open
tonyizdabezt wants to merge 1 commit into
Open
chore: apply position moves + drop dead Elo-category code#112tonyizdabezt wants to merge 1 commit into
tonyizdabezt wants to merge 1 commit into
Conversation
maiaEngine.js: the 'position' handler now applies any trailing 'moves ...' to the base FEN via chess.js instead of discarding them, making the engine UCI-correct. tensor.js: remove the unused Maia 2-style preprocess/boardToTensor and the Elo bucketing helpers (eloDict, createEloDict, mapToCategory) plus their all_moves.json fetches. Maia 3 passes raw Elo floats to the model and uses preprocessMaia3, so this code was unreachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maiaEngine.js:positionhandler now applies any trailingmoves ...to the base FEN via chess.js instead of discarding them, making the engine UCI-correct.tensor.js: remove the unused Maia 2-stylepreprocess/boardToTensorand Elo bucketing helpers (eloDict,createEloDict,mapToCategory) plus theirall_moves.jsonfetches. Maia 3 passes raw Elo floats and usespreprocessMaia3so this code was unreachable.