Skip to content

Fix AttributeError for no name directory service roles #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdodsley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AttributeError for no name directory service roles #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/878_dsr_noname.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- purefa_info - Fixed AttributeError when directory service role has no name
11 changes: 6 additions & 5 deletions plugins/modules/purefa_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,11 +535,12 @@ def generate_config_dict(module, array):
config_info["directory_service_roles"] = {}
roles = list(array.get_directory_services_roles().items)
for role in range(0, len(roles)):
role_name = roles[role].name
config_info["directory_service_roles"][role_name] = {
"group": getattr(roles[role], "group", None),
"group_base": getattr(roles[role], "group_base", None),
}
role_name = getattr(roles[role], "name", None)
if role_name:
config_info["directory_service_roles"][role_name] = {
"group": getattr(roles[role], "group", None),
"group_base": getattr(roles[role], "group_base", None),
}
config_info["ntp"] = array_info.ntp_servers
syslog_info = list(array.get_syslog_servers().items)
config_info["syslog"] = {}
Expand Down