Skip to content

fix aws clouddrive filter size #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewh1978 merged 1 commit into from
Nov 28, 2024
Merged

fix aws clouddrive filter size #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions px-deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,12 +1142,12 @@ func destroy_deployment(name string, destroyForce bool) {
panic(fmt.Sprintf("error listing aws instances %v \n", err.Error()))
}

// split aws_instances into chunks of 197 elements
// because of the aws DescribeVolumes Filter limit of 200 (197 instances + pxtype: data/kvdb/journal)
// split aws_instances into chunks of 196 elements
// because of the aws DescribeVolumes Filter limit of 200 (196 instances + pxtype: data/kvdb/journal/metadata)
// build slice of slices
aws_instances_split := make([]([]string), len(aws_instances)/197+1)
aws_instances_split := make([]([]string), len(aws_instances)/196+1)
for i, val := range aws_instances {
aws_instances_split[i/197] = append(aws_instances_split[i/197], val)
aws_instances_split[i/196] = append(aws_instances_split[i/196], val)
}

aws_volumes, err := aws_get_clouddrives(aws_instances_split, client)
Expand Down