Add more random functions to B311 check #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aripollak
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
for more information, see https://pre-commit.ci
ericwb
reviewed
Feb 17, 2025
| @@ -11,6 +11,9 @@ | |||
| bad = random.uniform() | |||
| bad = random.triangular() | |||
| bad = random.randbytes() | |||
| bad = random.sample() | |||
There was a problem hiding this comment.
These changes will require an update to the functional tests to update the count of the number of fail checks.
ericwb
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
This might result in more false positives, but likely as much as before with the other random functions. Okay for now, but in the future we may need to consider a better way to detect random used in a cryptographic fashion to isolate a more likely security issue.
|
Agreed. I was considering a separate feature request to at least allow some obvious non-cryptography cases through, like choices from a constant list or tuple of literals, but I'm not sure how common those would be. |
lukehinds
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1215.