Skip to content

Clean up some methods in dual module#629

Merged
bobbyxng merged 5 commits intodualfrom
dual-cleanup
Apr 8, 2026
Merged

Clean up some methods in dual module#629
bobbyxng merged 5 commits intodualfrom
dual-cleanup

Conversation

@brynpickering
Copy link
Copy Markdown

Suggestions to:

  • improve maintainability by spinning out repeated code into reusable functions
  • reduce memory overhead by avoiding creating flattened arrays where possible

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@FabianHofmann
Copy link
Copy Markdown
Collaborator

@bobbyxng pinging you on this :)

@bobbyxng
Copy link
Copy Markdown
Contributor

bobbyxng commented Apr 8, 2026

Just got back from holidays, sorry for the late feedback! @FabianHofmann @brynpickering
Thanks a lot @brynpickering for the improvements, this looks way more efficient. I tested this branch and everything still works as it's supposed to, so I will merge your changes into the dual branch.

@bobbyxng bobbyxng merged commit 3e0f512 into dual Apr 8, 2026
4 of 17 checks passed
@bobbyxng bobbyxng deleted the dual-cleanup branch April 8, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants