-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify dh systems #113
Modify dh systems #113
Conversation
6dcc649
to
27a2369
Compare
Validator ReportI am the Validator. Download all artifacts here.
|
Numeric | Status | NMAE | MAPE | |
---|---|---|---|---|
../KN2045_Bal_v4/csvs/price_statistics.csv | ||||
../KN2045_Bal_v4/csvs/cumulative_cost.csv | ||||
../KN2045_Bal_v4/csvs/weighted_prices.csv | ||||
../KN2045_Bal_v4/csvs/nodal_cfs.csv | ||||
../KN2045_Bal_v4/csvs/cfs.csv | ||||
../KN2045_Bal_v4/csvs/nodal_capacities.csv | ||||
../KN2045_Bal_v4/csvs/capacities.csv | ||||
../KN2045_Bal_v4/csvs/energy.csv | ||||
../KN2045_Bal_v4/csvs/curtailment.csv | ||||
../KN2045_Bal_v4/csvs/costs.csv | ||||
../KN2045_Bal_v4/csvs/nodal_supply_energy.csv | ||||
../KN2045_Bal_v4/csvs/supply_energy.csv | ||||
../KN2045_Bal_v4/csvs/supply.csv | ||||
../KN2045_Bal_v4/csvs/metrics.csv | ||||
../KN2045_Bal_v4/csvs/market_values.csv | ||||
../KN2045_Bal_v4/csvs/nodal_costs.csv | ||||
../KN2045_Bal_v4/csvs/prices.csv |
MAPE: Mean Absolute Percentage Error
NMAE: Mean Absolute Error on Min-Max Normalized Data
Status Thresholds: NMAE > 0.05 and MAPE > 5%
Comparing modify_dh_systems
(b8525b6) with main
(33916de).
Branch is 4 commits ahead and 4 commits behind.
Last updated on 2024-08-16 00:37:48 CEST
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @cpschau, I mainly have some code suggestions! Can you double check that the overall district heating share for Germany matches reported data from other sources? Can you plot total heat demand in Germany split by urban central, urban decentral and individual heating before and after your PR?
… input from function; renamed inputs
![]() |
So the central heating demand in Germany is much larger than previously in 2020? That's fine if it is fits better to other data sources... |
workflow/scripts/build_egon_data.py
Outdated
# | ||
# SPDX-License-Identifier: MIT | ||
""" | ||
Load and prepares the data of the eGo^N DemandRegio project about district |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eGo^N is written here differently than in the other script, check for the right spelling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add the link to the dataset like this
eGo^N DemandRegio project <https://opendata.ffe.de/project/demandregio/>
.
@cpschau looks really good, just two small comments and check if you can get the dictionary |
@lindnemi from my side this PR is ready to be merged! |
@cpschau great work! please complete the open points in our new PR requirements, then we're good to go:
thanks also to @lisazeyen for the detailed review |
very clean and well documented PR :) 👍 |
* added new script for DH modifications * function for update of urban heat loads * Preserve aggregate DH demand * remove subnodes * extra rule for egon data retrieval * Merge main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add dh progress * adjusted demand preservation for grid losses, improved comments * change script structure; modify dh shares in csv before prepare_sector_network * added docstring for script; changed logger config; excluded snakemake input from function; renamed inputs * change snakemake input file name in Snakefile * use technology mapping from metadata * changed spelling of eGo^n and adapted reference of data set in docstring * extended docstrings; added translation of 'Fernwaerme'; load snakemake input outside function * extended changelog; added config prefix * changed date format of prefix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Micha <[email protected]>
For a more accurate representation of the district heating sector in Germany, this PR integrates the DemandRegio data from the open ego project. The data is resolved on NUTS3 level and provides for each of the regions the household count for different heating technologies.
![nuts3_DH-share](https://private-user-images.githubusercontent.com/124347782/340289880-93752dec-ef08-448f-b1a1-0d8ad8ccef3c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTIwNjYsIm5iZiI6MTczOTAxMTc2NiwicGF0aCI6Ii8xMjQzNDc3ODIvMzQwMjg5ODgwLTkzNzUyZGVjLWVmMDgtNDQ4Zi1iMWExLTBkOGFkOGNjZWYzYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQxMDQ5MjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MjQ0ZDM5OTM2YmI0ZDQ2MzkxZmQxMDYxNjMwZmVjYzVjODdmNDRkYWJiZDMwODJiM2VjOWM4NWIyZmJkNDQ0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.rb9c36MxtURC0Tpx6NY_IdvcKaQh6VaUD46AnwEKaI8)
Egon data:
The count for households with access to district heating networks is used to correct the district heating and urban shares of the clusters calculated in
build_district_heat_share
.