feat: guild join requests by Soheab · Pull Request #3383 · Pycord-Development/pycord

Soheab · 2026-09-05T21:40:36Z

Summary

Closes #3340

This PR adds support for getting and taking action on guild join requests/applications.

API Docs: discord/discord-api-docs#8531

This adds:

PartialJoinRequest & JoinRequest & FormResponse
JoinRequestStatus (Enum)
JoinRequestFormFieldType (Enum)
JoinRequestAction (Enum)
Guild.fetch_join_requests()
HTTPClient.get_guild_join_requests() & HTTPClient.action_guild_join_request()
JoinRequestIterator
on_raw_guild_join_request_delete & RawGuildJoinRequestDeleteEvent
on_guild_join_request_create
on_guild_join_request_update

Codex was used for the added iterator and documentations.

Needs testing.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.
I have read the Contributing Guidelines.
AI Usage has been disclosed.
- If AI has been used, I understand fully what the code does

pycord-app · 2026-09-05T21:40:41Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3383/head:pr-3383
git checkout pr-3383

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3383/head

Paillat-dev · 2026-09-06T11:24:39Z

                data["guild_id"],
            )

+    def parse_guild_join_request_create(self, data: JoinRequestCreatePayload) -> None:


I wonder if we still would wanna cache these...

…Development/pycord into feat/guild-join-requests

Soheab · 2026-09-07T13:32:35Z

+        The ID of the guild the join request belongs to.
+    guild: :class:`discord.Guild`
+        The guild the join request belongs to.
+    application_status: :class:`JoinRequestStatus`


Suggested change

application_status: :class:`JoinRequestStatus`

application_status: :class:`JoinRequestStatus` | :data:`None`

Soheab · 2026-09-07T13:36:50Z

+    guild: :class:`discord.Guild`
+        The guild the join request belongs to.


Suggested change

guild: :class:`discord.Guild`

The guild the join request belongs to.

Soheab · 2026-09-07T13:38:41Z

+
+    @property
+    def guild(self) -> Guild | None:
+        """Optional[:class:`discord.Guild`]: The guild the join request belongs to.


Suggested change

"""Optional[:class:`discord.Guild`]: The guild the join request belongs to.

""":class:`discord.Guild` | :data:`None`: The guild the join request belongs to.

Soheab · 2026-09-07T13:48:29Z

+        ----------
+        action: :class:`JoinRequestAction`
+            The action to take on the join request.
+        rejection_reason: Optional[:class:`str`]


Suggested change

rejection_reason: Optional[:class:`str`]

rejection_reason: :class:`str` | :data:`None`

vmphase

Please use a typechecker before pushing commits.

vmphase · 2026-09-08T14:33:02Z

+    def create_join_request(self, data: JoinRequestPayload) -> JoinRequest:
+        from .guild_join_request import JoinRequest
+
+        return JoinRequest(guild=self.guild, state=self.state, data=data)


JoinRequest no longer takes a guild kwarg; will cause a TypeError.

Suggested change

return JoinRequest(guild=self.guild, state=self.state, data=data)

return JoinRequest(state=self.state, data=data)

vmphase · 2026-09-08T14:35:08Z

+        response: str | int | bool | None = data.get("response")
+        if (
+            self.field_type is JoinRequestFormFieldType.MULTIPLE_CHOICE
+            and isinstance(response, int)
+            and self.choices is not None
+            and 0 <= response < len(self.choices)
+        ):
+            self.choice_index = response
+            self.response = self.choices[self.choice_index]


self.response only ever gets set inside the MULTIPLE_CHOICE branch. For TERMS, TEXT_INPUT and PARAGRAPH it stays None forever, even though data.get("response") may contain some value. Not sure it's intended...

vmphase · 2026-09-08T14:38:03Z

+        "form_responses",
+        "rejection_reason",
+        "reviewed_at",
+        "status",


The attribute is application_status, not status, which is inherited from PartialJoinRequest and doesn't need to be re-slotted here.

Suggested change

"status",

vmphase · 2026-09-08T14:40:19Z

+    .. versionadded:: 2.9
+        If the join request has already been approved or rejected, this will raise :exc:`ValueError`.


Huh?

Suggested change

.. versionadded:: 2.9

If the join request has already been approved or rejected, this will raise :exc:`ValueError`.

.. versionadded:: 2.9

vmphase · 2026-09-08T14:41:21Z

+)
+from .mixins import Hashable
+
+__all__ = ("FormResponse", "JoinRequest")


Suggested change

__all__ = ("FormResponse", "JoinRequest")

__all__ = ("FormResponse", "JoinRequest", "PartialJoinRequest")

vmphase · 2026-09-08T14:41:46Z

+        Usage ::
+
+            async for request in guild.join_requests(limit=250):
+                print(request.user, request.status)


Suggested change

print(request.user, request.status)

print(request.user, request.application_status)

feat: guild join requests

7a37aca

Soheab added this to the 2.9.0 milestone Sep 5, 2026

Soheab self-assigned this Sep 5, 2026

Soheab requested review from a team and Lulalaby September 5, 2026 21:40

Soheab added priority: medium Medium Priority feature Implements a feature hold: changelog This pull request is missing a changelog entry labels Sep 5, 2026

Soheab requested a review from DA-344 September 5, 2026 21:40

Soheab added hold: testing This pull request requires further testing hold: discussion This pull request needs to be further discussed between maintainers labels Sep 5, 2026

Soheab requested a review from a team as a code owner September 5, 2026 21:40

github-project-automation Bot added this to Pycord Sep 5, 2026

Soheab requested a review from ToothyDev September 5, 2026 21:40

github-project-automation Bot moved this to Todo in Pycord Sep 5, 2026

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Sep 5, 2026

style(pre-commit): auto fixes from pre-commit.com hooks

57b20aa

Paillat-dev self-requested a review September 5, 2026 21:54

Paillat-dev modified the milestones: 2.9.0, 2.9.0rc1 Sep 5, 2026

Soheab and others added 4 commits September 6, 2026 00:03

chore: fix typo in http method

8896587

chore: events

c6d7506

Guild.fetch_join_requests -> Guild.join_requests

321c279

style(pre-commit): auto fixes from pre-commit.com hooks

8bba006

Paillat-dev requested changes Sep 6, 2026

View reviewed changes

pullapprove4 Bot removed PA: All Contributors pending PA: Maintainers pending labels Sep 6, 2026

vmphase requested changes Sep 6, 2026

View reviewed changes

Soheab and others added 2 commits September 7, 2026 11:16

refactor: requested changes and (partial) refactor

4d8b034

style(pre-commit): auto fixes from pre-commit.com hooks

ec90827

Soheab requested review from Paillat-dev and vmphase September 7, 2026 09:17

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Sep 7, 2026

Soheab added 6 commits September 7, 2026 11:19

chore: revert BaseJoinRequest

d26dd70

Merge branch 'feat/guild-join-requests' of https://github.com/Pycord-…

656bc51

…Development/pycord into feat/guild-join-requests

chore: actioned_by_user -> actioned_by

d970127

chore: parse choices response

a37897a

fix: duplicated guild attribute

3154440

fix: duplicated guild and user attributes

07c9a79

Soheab commented Sep 7, 2026

View reviewed changes

vmphase requested changes Sep 8, 2026

View reviewed changes

pullapprove4 Bot removed the PA: All Contributors pending label Sep 8, 2026

Soheab marked this pull request as draft September 8, 2026 14:57

pullapprove4 Bot removed the PA: Maintainers pending label Sep 8, 2026

	application_status: :class:`JoinRequestStatus`
	application_status: :class:`JoinRequestStatus` \| :data:`None`

		guild: :class:`discord.Guild`
		The guild the join request belongs to.

	"""Optional[:class:`discord.Guild`]: The guild the join request belongs to.
	""":class:`discord.Guild` \| :data:`None`: The guild the join request belongs to.

	rejection_reason: Optional[:class:`str`]
	rejection_reason: :class:`str` \| :data:`None`

	return JoinRequest(guild=self.guild, state=self.state, data=data)
	return JoinRequest(state=self.state, data=data)

		.. versionadded:: 2.9
		If the join request has already been approved or rejected, this will raise :exc:`ValueError`.

	__all__ = ("FormResponse", "JoinRequest")
	__all__ = ("FormResponse", "JoinRequest", "PartialJoinRequest")

	print(request.user, request.status)
	print(request.user, request.application_status)

Uh oh!

Uh oh!

Conversation

Soheab commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app Bot commented Sep 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Soheab Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmphase left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Soheab commented Sep 5, 2026 •

edited

Loading

Soheab Sep 7, 2026 •

edited

Loading