Skip to content

New GAMS solver interface, writer, and solution loader. #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnhTran01 wants to merge 35 commits into
base: main
Choose a base branch
from
+1,935 −0
Open

New GAMS solver interface, writer, and solution loader. #3683

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
1177492
Added new GAMS solver interface, writer, and solution loader. WIP: un…
Aug 7, 2025
2385654
Ran black -S -C on commited files
Aug 7, 2025
b36086f
Typo!
mrmundt Aug 7, 2025
e91e480
Added ignore checking for constant in the objective function during w…
Aug 7, 2025
b060096
Added support for add_options for multiple solver_options
Aug 8, 2025
96ba646
typo
Aug 8, 2025
b0f16a3
ran black formatter
Aug 8, 2025
dde656c
added add_options in the solver_interface
Aug 8, 2025
3476f72
Fixed bug with unable to create tmpdir. Updated test_gams_v2.py
Aug 8, 2025
ddfd98c
Merge branch 'main' into GAMS_new_solver_interface
AnhTran01 Aug 8, 2025
eb0a3db
Added handling single bounded variable case (None,#) or (#, None)
Aug 10, 2025
c6d2d01
Match solver interface and writer configs to prevent implicit definit…
Aug 11, 2025
2a6dcb7
Added new gams solver interface for test_all_solvers_list()
Aug 12, 2025
b6ead27
Fixed bug of handling valid ub when writing pyomo expression
Aug 12, 2025
89f80e0
Fixed bug when using ComponentMap to extract duals in gms_sol_reader.py
Aug 13, 2025
b0c3450
Corrected handling of solution_loader. Implemented bounded constraint…
Aug 14, 2025
a9df1d7
Added offdigit based on error log message suggestion
Aug 14, 2025
e04c89f
Merge branch 'main' into GAMS_new_solver_interface
mrmundt Aug 15, 2025
518758e
Fixed bug of extracting constraint dual when alias exits (for bounded…
Aug 18, 2025
a2ef9cc
Added aliases as part of parse_dat_results to be consistent with pars…
Aug 18, 2025
c33095d
Removed code duplication between the solver interface and writer by p…
Aug 18, 2025
f609ca2
Revised code based on John's review. WIP: Handling rehash within avai…
Aug 19, 2025
ec5aa6a
Re-added config into available and version, and deprecated test that …
Aug 19, 2025
e760a1c
Merge branch 'main' into GAMS_new_solver_interface
mrmundt Aug 19, 2025
7bb817b
Sanity check config.writer_config.put_results_format without setdefault
Aug 20, 2025
72beeaf
Allow user to modify writer config via solver_options. Fixed bug of s…
Aug 20, 2025
3dc83ca
Merge branch 'Pyomo:main' into GAMS_new_solver_interface
AnhTran01 Aug 20, 2025
5c87b75
Corrected exeception type raised when solver return infeasible. Added…
Aug 20, 2025
d6aa9ff
Corrected test_gams_v2.py to match error raised. Corrected error mess…
Aug 20, 2025
aba0eed
Merge branch 'Pyomo:main' into GAMS_new_solver_interface
AnhTran01 Aug 20, 2025
f85d217
Prevent rewrite of termination condition in modelstat if the value is…
Aug 20, 2025
0e94742
Added an gams_solver_options (handled via solver_option in solve). Ad…
Aug 20, 2025
9d5758e
Divided solver and model termination condition into separate config.
Aug 21, 2025
d1285e3
Merge branch 'Pyomo:main' into GAMS_new_solver_interface
AnhTran01 Aug 21, 2025
2973d9c
Added unittest skipif for linux_3.9_slim and linux_3.12_numpy failed …
Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pyomo/repn/plugins/gams_writer_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,11 @@ def write(self, model):
con_list[label] = declaration + definition + bounds
self.var_symbol_map.addSymbol(obj, label)

# Write the GAMS model
ostream.write("$offlisting\n")
# $offdigit ignores extra precise digits instead of erroring
Copy link

@boxblox boxblox Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the error that you were seeing that prompted this addition? maybe something was being set above 1e300?

Copy link
Contributor Author

@AnhTran01 AnhTran01 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the previous commit test (b0c3450), the listing file output error message is "Too many digits in number $offdigit can be used to ignore trailing digits"

Copy link

@boxblox boxblox Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but do you know what triggered this? which test was causing this error?

Copy link
Contributor Author

@AnhTran01 AnhTran01 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back to check the failed test. The following tests that triggered the "Too many digits error" are:

  1. TestSolvers.test_equality
  2. TestSolvers.test_linear_expression
  3. TestSolvers.test_mutable_param_with_range
  4. TestSolvers.test_param_changes
  5. TestSolvers.test_no_objective
  6. TestSolvers.test_time_limit
  7. TestLegacySolverInterface.test_param_updates

By testing locally, I see there are trailing decimal places and not the cases of 1e300 or large numbers.

ostream.write("$offdigit\n\n")

#
# Write out variable declaration
#
Expand Down
Loading