Change Constant Polling to Only On Click#35
Open
JeremyTsaii wants to merge 3 commits into
Open
Conversation
added 3 commits
December 3, 2020 15:45
|
Approve. |
HenrySoftwareStudio
approved these changes
Dec 19, 2021
andythsu
approved these changes
Jan 12, 2022
|
@JeremyTsaii make sure to resolve conflicts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having constant polling every second, only poll once the submit button is clicked. I think this is a better structure. I will also probably draw on this when implementing the discuss pushing, as there is a "Post" button and the URL is only visible after a second or so when the post is actually made. Let me know what you think.