-
Notifications
You must be signed in to change notification settings - Fork 144
Qedma: QESEM qiskit function + OBP addon tutorial #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
|
|
|
Thank you for the draft @oria-qedma! Is it possible to scale this up to 30+ qubits? cc: @miamico @pandasa123 |
|
Yes it is possible to run this using a larger number of qubits , we just have to play a bit with the parameters to keep the QPU runtime short enough on the one hand but still make sure the example shows some interesting behavior on the other hand. |
|
More feedback from the team: It would be interesting to include a result+depth comparison when using OBP+ QESEM versus just QESEM. Thoughts? cc: @pandasa123 @jenglick |
|
Hi! I'm working on fixing the lint errors. I don't have write access to your branch, but I opened a PR on your fork, so if you can approve/merge it, that should bring those fixes into this PR. Thanks! |
|
Cool, thanks for the draft! Here's some comments for you to work on:
|
Hey @valeriechiang , Thanks fo the feedback! Yeah it could be a nice comparison. Currently the notebook takes around 20 minutes of QPU time (for all the trotter steps up to 9), I'm afraid it might be intimidating for users if it were to take double the time (approximately, haven't tried it yet) let's say 50 minutes.. What do you think? |
Here I guess you meant H2 sections (if i compare to the referenced tutorial)
Hey, thanks for the detailed feedback. I merged the PR and updated the notebook according to a few of the comments (checked them above). I will commit the changes and continue with the other comments later this week. |
|
Authors: If there is an option along the right-hand side of this PR to "Allow edits from maintainers" - can you please enable it, if you don't mind? That way we can commit to your branch. |
@talishnaider-qedma This is a good point. Maybe we can make the comparison to just QESEM optional (and add a disclaimer note that it will take ~50 minutes)? Then we can keep the overall tutorial time estimate as 20 minutes. |
@abbycross I don't see such an option, maybe because I don't have admin rights to the fork? (I think maybe @assafb created the fork originally for other documentation work) |
Thanks for checking! - it's certainly possible that it's an admin-only option. |
|
Hi @talishnaider-qedma @oria-qedma any updates for the next draft? We are waiting on the rest of the checkboxes and look forward to reviewing :) Thank you for your collaboration! |
|
Hey @valeriechiang the next draft should be ready by the end of the week :) |
I elaborated about the model, QESEM and the way QESEM hadles the observables outputted by OBP in the background let me know if these seem clear to you.
Here I guess you meant H2 sections (if i compare to the referenced tutorial)
Added a plot of the device and the selected qubits. I would have preferred the plot to look like map view of a heron device but couldn't find a fitting function in qiskit.visualization, so if you have any suggestions let me know.
Since we wanted to emphasis 2D cases MPS wasn't quite fitting I added 2 more subgraphs for 35 and 42 qubits with precalculated ideal values (using bp peps).
Hey @valeriechiang , I updated the notebook according to the remaining comments (checked them above). Added a few questions and notes between the checkboxes if you could review them. Let me know if you have any other suggestions to make this tutorial clearer and more accessible :) |
…ted results for 35 and 42 qubits subgraphs. Changed title of notebook. And few small changes for clarity.
Regarding this, I thought about it and we do show a QPU time comparison of OBP + QESEM versus just QESEM which shows a reduction of 50% in QPU time (for the 5 trotter steps circuit). As far as I understand, the OBP optimization doesn’t affect the observable results themselves, so I think the comparison might be redundant. |
This is a draft of a Qesem QF tutorial showing simulation of 2d transverse field Ising model with Qesem error mitigation combined with qiskit operator backpropagation module.
Feedback from IBM team is welcome.
FYI @assafb