Skip to content

Remove version on client - #2443

Open
Goyo (korgan00) wants to merge 10 commits into
mainfrom
client-interface-improvemnts
Open

Remove version on client#2443
Goyo (korgan00) wants to merge 10 commits into
mainfrom
client-interface-improvemnts

Conversation

@korgan00

@korgan00 Goyo (korgan00) commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove version parameter on client since is not used at this moment.

Details and comments

Checklist

  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have added a release note for any user-facing change (new feature, bug fix, deprecation, or breaking change), or this PR has no user-facing changes.

@korgan00
Goyo (korgan00) marked this pull request as ready for review August 31, 2026 14:05
@korgan00
Goyo (korgan00) requested a review from a team as a code owner August 31, 2026 14:05

@ElePT Elena Peña Tapia (ElePT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am pretty sure nobody was using this feature, we are trying to implement stricter rules on deprecations and removals. This means sticking to a deprecation period before submitting the removal PR as we did, for example, with #2283 (deprecation) and #2354 (removal). I think we should do the same here. A new PR first deprecating the argument (with its respective release note) + a follow-up on a future release with this removal (and a release note).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants