Unify BoxDuration and Delay duration representation#15624
Unify BoxDuration and Delay duration representation#15624arnavk23 wants to merge 5 commits intoQiskit:mainfrom
Conversation
Renamed BoxDuration to InstructionDuration to make it a general-purpose type that can be used for both Box and Delay operations. The new type represents a duration value that can be either a concrete Duration or a delayed-resolution expression (Expr). Added InstructionDuration::from_delay_unit_and_param() method to convert from Delay's representation (DelayUnit + Param) to the unified InstructionDuration representation. All usages of BoxDuration across the codebase have been updated to use InstructionDuration instead. Fixes Qiskit#15377
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 21478368130Details
💛 - Coveralls |
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Renamed BoxDuration to InstructionDuration to make it a general-purpose type that can be used for both Box and Delay operations. The new type represents a duration value that can be either a concrete Duration or a delayed-resolution expression (Expr).
Fixes #15377