Fix ConsolidateBlocks to merge Unitary gates unconditionally

[arnavk23]

Summary

Fix ConsolidateBlocks to consolidate blocks of Unitary gates unconditionally, enabling better merging before routing/layout.

Details and comments

• Modified consolidation logic to detect and consolidate blocks consisting entirely of Unitary gates, regardless of basis_gates or target configuration.
• Fixes Improve merging in Consolidate Blocks #15631

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

• @Qiskit/terra-core

[mtreinish]

Thanks for looking at this but the proposed change here is not correct and is not a change that should be made. In the underlying issue if the pass is not consolidating blocks which should be then there is likely a bug in the pass code around the conditions on whether an identified block should be consolidated or not.

[coveralls]

Pull Request Test Coverage Report for Build 21647534016

Details

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• 18 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.02%) to 87.955%

---

Files with Coverage Reduction	New Missed Lines	%
crates/circuit/src/parameter/symbol_expr.rs	1	72.91%
crates/qasm2/src/lex.rs	5	91.52%
crates/qasm2/src/parse.rs	12	97.15%

Totals
Change from base Build 21615363168:	-0.02%
Covered Lines:	100008
Relevant Lines:	113703

---

💛 - Coveralls