Open
Conversation
Collaborator
|
One or more of the following people are relevant to this code:
|
Collaborator
|
One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds implementations of the qpy module
dumpandloadfunctions with Rust, making it possible to have a full QPY flow directly in Rust without Python.Details and comments
This PR adds a top level
QPYFilestruct to the rust QPY framework, handling the general file metadata and the the circuits. A new file,interface.rs, handles the actualdumpandloadfunctions. We have python wrappers that are called from python'sinterface.pyfor supported versions.Since we still don't have a pure rust
QuantumCircuit, the rust functionsdump_qpyandload_qpystill have Python remnants in their I/O. In particular,load_qpyreturns python circuits (asPy<PyAny>) anddump_qpyaccepts theQuantumCircuitDatastruct which is used as a transition layer from python'sQuantumCircuit.The circuit offset table, present in QPY17, is actually not required at all since all the size data for a given circuit is included in its serialization. Moreover, computing the circuit offset table is not trivial in the binrw framework. So to avoid complicating our data structures with a field that will become obsolete in QPY18, I added another struct,
QPY17File. When convertingQPYFiletoQPY17Filethe circuits are serialized, the offset table is correctly calculated, and thenQPY17Filecan also be written using the standard binrw macros.