fix: don't panic anymore when there is no column value matching in insert into #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You're the best @fabriceclementz 🦾 - I am also waiting for the respond from the people on #134 |
Contributor
|
Hi @fabriceclementz 👋🏽 , I am not sure it is still a valid PR? |
Contributor
Author
|
Hi @evoxmusic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @evoxmusic
I think this PR should fix the panic mentioned in #134 but I failed to reproduce this bug so I just removed the unwrap to gracefully handle the case where there is no matching value for a column.
I let this PR in draft for now, maybe we can have the part of the dump causing this panic so we can validate It's not a problem in the dump-parser.
Closes #134