Conversation
gabalafou
requested review from
pavithraes,
rgommers and
trallard
as code owners
August 23, 2024 09:51
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Attempting to self-review this PR, I realize that my editor's auto-formatting added too many changes. I'm going to redo and update this PR. |
gabalafou
marked this pull request as draft
August 23, 2024 09:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR #873 for some context.
Our blog post build code takes the blog title from the post metadata and renders it both in the HTML
<title>tag as well as at the top of the page (in an<h1>after #873). For this reason, the body of the blog post markdown should not contain any level-1 headings, only level-2 and up.Most blog posts in the repo have been written this way, but there were some exceptions that this PR attempts to correct.
Note: my editor also introduced a number of formatting and whitespace changes. If these add too much review burden, please let me know and I'll redo the PR so that it strictly only has heading changes.