[BLOG] add Multi-dimensional Sparse Arrays in SciPy #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anushkasuyal
requested review from
pavithraes,
trallard and
rgommers
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
izaid
reviewed
Sep 20, 2024
izaid
reviewed
Sep 20, 2024
…anushkasuyal/Quansight-website into multi-dimensional-sparse-arrays
melissawm
reviewed
Sep 23, 2024
|
|
||
| By the end of this stage, I had become fairly confident that the entire COO codebase could be extended to n-dimensions. | ||
|
|
||
| I then moved on to the second stage, which involved tackling the fundamental operations in linear algebra, `matmul`, `dot`, and `tensordot`. |
There was a problem hiding this comment.
I suggest linking to the documentation on those - just for completeness.
There was a problem hiding this comment.
Would this be to the SciPy sparse documentation (because I haven't added docstrings for tensordot which is a new addition to the codebase), or linking to the NumPy documentation?
|
Thanks @melissawm ! I've made the alt text a bit more descriptive, and have added the source links for the images, at 554fe2b. |
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
|
I've addressed all suggestions! I think this is ready to merge now. :) |
melissawm
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Looks great to me, thanks @anushkasuyal !
@pavithraes can we merge soon? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR is made to add the blog post describing the work I have done on extending n-dimensional support for COOrdinate sparse arrays in SciPy during my summer internship under the mentorship of @rgommers and @izaid, to the Quansight Labs blog.