Draft
Conversation
Member
Author
|
This is still a work in progress, I'm not sure things are in the right place or if there are more opportunities for abstractions. |
Member
|
Hi @davidbrochart , there is no python part to invoke the widget? |
Member
Author
|
It's currently part of jupyter-server/jupyverse#420, which has an InputModel. |
davidbrochart
commented
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR,
yjs-widgetsonly supports client-side execution, where JupyterLab talks to the kernel through the kernel protocol over WebSocket. In this execution mode, widgets are created and synchronized client-side through Comms.This PR implements the rendering of widgets using server-side execution, where JupyterLab doesn't handle the kernel protocol over WebSocket, but instead uses a REST API to trigger cell execution, and reacts to notebook changes through its shared model.
It will allow to have jupyterlab-collaborative-input use
yjs-widgetsinstead of using the notebook shared model as a container for the input model. An input widget is provided in this PR.