-
Notifications
You must be signed in to change notification settings - Fork 13
fix: Replace \d
with [0-9]
in regexes to avoid sampling non-ascii digits
#149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+307
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2901 2901
=========================================
Hits 2901 2901 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
delsner
commented
Sep 19, 2025
\d
with [0-9]
to avoid sampling non-ascii digits
\d
with [0-9]
to avoid sampling non-ascii digits\d
with [0-9]
in regexes to avoid sampling non-ascii digits
borchero
reviewed
Oct 17, 2025
borchero
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using
\d
in regular expressions for string columns results in non-ascii digits in sampled values. This is unexpected and breaks with the usual behavior of using\d
as a metacharacter for ASCII digits only, i.e.,[0-9]
.Changes
sample()
by replacing\d
with[0-9]
\d