Fix breakage caused by changes in formulaic #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanmart
requested review from
MarcAntoineSchmidtQC,
xhochy,
jtilly and
lbittarello
as code owners
lbittarello
reviewed
Dec 4, 2024
Comment on lines
+26
to
+29
| try: | ||
| from formulaic.materializers.base import EncodedTermStructure | ||
| except ImportError: | ||
| from formulaic.materializers.types.formula_materializer import EncodedTermStructure |
There was a problem hiding this comment.
Could we use the formulaic version to select the import path instead of a try/except block?
There was a problem hiding this comment.
Unfortunately I don't know in which version the change will appear. It's on main now, and my guess is 1.1, but I'm not sure.
lbittarello
approved these changes
Dec 4, 2024
|
@stanmart, I hijacked your PR to also update a CI runner so that the CI would pass. |
|
oops, I thought it would be a simple fix. Not the case. I will open a different PR to fix this. |
MarcAntoineSchmidtQC
approved these changes
Dec 4, 2024
|
haha, all good, I'll merge it then |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like formulaic might be considering the
EncodedTermStructurea private class based on the fact that it is being moved in a non-major release. A bigger refactor of theformulamodule might be worth considering at some point now that formulaic reached 1.0 and is more stable. Until then, this PR provides a quick fix for #422.Checklist
CHANGELOG.rstentry