Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liz speedup cat #6

Merged
merged 15 commits into from
Jul 13, 2020
Merged

Liz speedup cat #6

merged 15 commits into from
Jul 13, 2020

Conversation

ElizabethSantorellaQC
Copy link
Contributor

@ElizabethSantorellaQC ElizabethSantorellaQC commented Jul 9, 2020

See #3

Split categorical-dense is now competitive with split0.1 and sparse, but not always fastest. There is more to do, but no harm in merging this. I've parallelized stuff, so I expect a greater speedup on a machine with more cores.

More performance benchmarks available in the README here: https://github.com/Quantco/quantcore.matrix/tree/benchmark

                                                                   library_name   storage  threads  single_precision  n_iter  runtime  offset  intercept  num_nonzero_coef  obj_val  rel_obj_val
problem_name                    num_rows regularization_strength                                                                                                                                
wide-insurance-weights-l2-gamma 24944    0.001                    quantcore-glm     dense        8             False       8   0.4407   False     6.9434               273   8.1218   0.0000e+00
                                         0.001                    quantcore-glm  split0.1        8             False       8   0.1080   False     6.9434               273   8.1218   0.0000e+00
                                         0.001                    quantcore-glm       cat        8             False       8   0.1376   False     6.9434               273   8.1218   1.7764e-15
                                         0.001                    quantcore-glm    sparse        8             False       8   0.1653   False     6.9434               273   8.1218   1.7764e-15

Copy link
Member

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REALLY exciting.

@ElizabethSantorellaQC
Copy link
Contributor Author

Needs to be merged first: Quantco/glum#264

Copy link
Collaborator

@tbenthompson tbenthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate review of the C++ parts: Looks great!

@ElizabethSantorellaQC ElizabethSantorellaQC merged commit a840067 into master Jul 13, 2020
@ElizabethSantorellaQC ElizabethSantorellaQC deleted the liz_speedup_cat branch July 13, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants