feat(qsystem): add RNG.random_advance()

[qartik]

Part of https://github.com/quantinuum-dev/hugrverse/issues/175

depends on:

• feat(tket-qsystem)!: Support random_advance platform call tket2#1170
• feat!: Use borrow_array instead of value_array for array lowering #1166

[github-actions]

Bencher Report

Branch	feat-random_advance
Testbed	Linux

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
tests/benchmarks/test_big_array.py::test_big_array_check	📈 view plot 🚷 view threshold	661,190.68 µs (-13.87%) Baseline: 767,660.82 µs	806,043.86 µs (82.03%)
tests/benchmarks/test_big_array.py::test_big_array_compile	📈 view plot 🚷 view threshold	1,535,463.51 µs (-50.92%) Baseline: 3,128,784.69 µs	3,285,223.92 µs (46.74%)
tests/benchmarks/test_big_array.py::test_big_array_executable	📈 view plot 🚷 view threshold	7,294,042.80 µs (-19.77%) Baseline: 9,091,601.91 µs	9,546,182.01 µs (76.41%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_check	📈 view plot 🚷 view threshold	47,349.23 µs (-30.86%) Baseline: 68,486.61 µs	71,910.94 µs (65.84%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile	📈 view plot 🚷 view threshold	84,095.27 µs (-16.48%) Baseline: 100,683.10 µs	105,717.25 µs (79.55%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_executable	📈 view plot 🚷 view threshold	577,971.26 µs (-26.07%) Baseline: 781,764.01 µs	820,852.21 µs (70.41%)
tests/benchmarks/test_prelude.py::test_import_guppy	📈 view plot 🚷 view threshold	24.14 µs (-9.34%) Baseline: 26.62 µs	27.95 µs (86.35%)

🐰 View full continuous benchmarking report in Bencher

[github-actions]

Bencher Report

Branch	feat-random_advance
Testbed	Linux

🚨 2 Alerts

Benchmark	Measure Units	View	Benchmark Result (Result Δ%)	Upper Boundary (Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile	hugr_nodes nodes x 1e3	📈 plot 🚷 threshold 🚨 alert (🔔)	6.59 x 1e3 (+32.64%) Baseline: 4.97 x 1e3	5.02 x 1e3 (131.33%)
tests/benchmarks/test_big_array.py::test_big_array_compile	hugr_bytes bytes x 1e3	📈 plot 🚷 threshold 🚨 alert (🔔)	135.90 x 1e3 (+4.99%) Baseline: 129.44 x 1e3	130.74 x 1e3 (103.95%)

Click to view all benchmark results

Benchmark	hugr_bytes	Benchmark Result bytes x 1e3 (Result Δ%)	Upper Boundary bytes x 1e3 (Limit %)	hugr_nodes	Benchmark Result nodes (Result Δ%)	Upper Boundary nodes (Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile	📈 view plot 🚷 view threshold 🚨 view alert (🔔)	135.90 x 1e3 (+4.99%) Baseline: 129.44 x 1e3	130.74 x 1e3 (103.95%)	📈 view plot 🚷 view threshold 🚨 view alert (🔔)	6,590.00 (+32.64%) Baseline: 4,968.39	5,018.07 (131.33%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile	📈 view plot 🚷 view threshold	19.77 x 1e3 (-9.60%) Baseline: 21.86 x 1e3	22.08 x 1e3 (89.51%)	📈 view plot 🚷 view threshold	606.00 (-11.94%) Baseline: 688.17	695.05 (87.19%)

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (f9ef42b) to head (36aed85).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         123      123           
  Lines       11432    11435    +3     
=======================================
+ Hits        10683    10686    +3     
  Misses        749      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ss2165]

Looks good. It would be nice if the rng test could be an execution test as well as validation (i.e. to check the number returned after stepping back is the same as the last one). I think this just involves pointing the hugr-qis compiler dependency also at the branch?

[qartik]

It would be nice if the rng test could be an execution test as well as validation (i.e. to check the number returned after stepping back is the same as the last one).

Done.

[qartik]

Probably best to make a new selene-hugr-qis-compiler release instead of trying to add LLVM deps to the CI.

[qartik]

@ss2165 do we need any more work on this PR? Or is it ready for approval?

[ss2165]

👍 can be merged when the tket2 repo releases are made

[qartik]

Now, we wait until the following is merged

• feat!: Use borrow_array instead of value_array for array lowering #1166

[qartik]

just sorting