feat!: improved error handling in modifiers#1580
Draft
nicolaassolini-qntm wants to merge 2 commits intomainfrom
Draft
feat!: improved error handling in modifiers#1580nicolaassolini-qntm wants to merge 2 commits intomainfrom
nicolaassolini-qntm wants to merge 2 commits intomainfrom
Conversation
Collaborator
|
This PR contains breaking changes to the public Python API. Breaking changes summary |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 93.55% 93.56% +0.01%
==========================================
Files 130 130
Lines 12274 12347 +73
==========================================
+ Hits 11483 11553 +70
- Misses 791 794 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1288
Solved the issue related to error messages with ownership violation in modifier blocks by adding a special flag in
check_cfgto state when we are checking the modifier block.Updated the
NotOwnErrorto handle this special caseBREAKING CHANGE: added a flied
first_modifier_node: ast.exprto guppylang_internals/nodes.py:ModifiedBlockBREAKING CHANGE: change the fieldis_call_arg changein guppylang_internals/checker/errors/linearity.py:NotOwnedErrorfrom a boolean to an Enum