Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
==========================================
- Coverage 82.16% 81.99% -0.17%
==========================================
Files 239 239
Lines 42989 43158 +169
Branches 38901 39070 +169
==========================================
+ Hits 35320 35386 +66
- Misses 5678 5769 +91
- Partials 1991 2003 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
427c14a to
b90b1d6
Compare
851b928 to
2da3d4c
Compare
This PR adds more helpful error messages to model import to help debug errors that may occur during the migration to `hugr-model` as the default serialisation format (see #2260). The errors are still far from ideal, but should already provide a significant improvement. We hide the internals of `ImportError` in order to allow for the error messages to improve without incurring breaking changes. This PR also implements a remaining `todo!()` concerning importing tuple types. BREAKING CHANGE: The internals of `ImportError` are hidden.
2da3d4c to
817cb9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
hugr-model: 0.20.0 -> 0.21.0hugr-core: 0.20.0 -> 0.21.0 (⚠ API breaking changes)hugr-llvm: 0.20.0 -> 0.21.0 (✓ API compatible changes)hugr-passes: 0.20.0 -> 0.21.0hugr: 0.20.0 -> 0.21.0 (✓ API compatible changes)hugr-cli: 0.20.0 -> 0.21.0⚠
hugr-corebreaking changesChangelog
hugr-modelhugr-corehugr-llvmhugr-passeshugrhugr-cliThis PR was generated with release-plz.