Skip to content

test: Improve ComposablePass tests#2688

Merged
aborgna-q merged 1 commit intomainfrom
ab/composable-tests
Nov 18, 2025
Merged

test: Improve ComposablePass tests#2688
aborgna-q merged 1 commit intomainfrom
ab/composable-tests

Conversation

@aborgna-q
Copy link
Copy Markdown
Collaborator

Suggestion missing from #2636, makes sure we test the actual implementation rather than the dummy one.

drive-by: Improve name impl for ComposedPass

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (fcd1026) to head (5f86c37).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
+ Coverage   83.43%   83.45%   +0.01%     
==========================================
  Files         264      264              
  Lines       51601    51604       +3     
  Branches    47069    47069              
==========================================
+ Hits        43055    43067      +12     
+ Misses       6162     6153       -9     
  Partials     2384     2384              
Flag Coverage Δ
python 91.53% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aborgna-q aborgna-q added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 775fbd9 Nov 18, 2025
29 checks passed
@aborgna-q aborgna-q deleted the ab/composable-tests branch November 18, 2025 12:36
aborgna-q added a commit that referenced this pull request Nov 24, 2025
Suggestion missing from #2636, makes sure we test the actual
implementation rather than the dummy one.

drive-by: Improve `name` impl for ComposedPass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants