Skip to content

ci: Don't create python releases as drafts#2950

Merged
aborgna-q merged 1 commit intomainfrom
ab/release-please-draft
Mar 16, 2026
Merged

ci: Don't create python releases as drafts#2950
aborgna-q merged 1 commit intomainfrom
ab/release-please-draft

Conversation

@aborgna-q
Copy link
Collaborator

This partially reverts #2892.

The idea of that PR was to create the python releases as Draft while wheels are being built, only to mark them as ready once the wheels have been submitted.

I had to change the trigger for the wheel-building workflow from release: published to push: tags, since apparently draft releases do not trigger workflows (https://github.com/orgs/community/discussions/7118) 🫠

Turns out, creating a draft release not only does not trigger release workflows but also it doesn't create tags 🫠

So here instead we are creating a non-draft release, and marking it as draft when the wheels building workflow start.
This won't help when we want to start using github's new immutable releases, but at least mimics the behaviour for now.

(Ideally we'd just create a tag plus the draft release, but we don't have control over release-please's behaviour there).

This partially reverts commit 7890e2f.
@aborgna-q aborgna-q requested a review from cqc-alec March 16, 2026 16:45
@aborgna-q aborgna-q requested a review from a team as a code owner March 16, 2026 16:45
@aborgna-q aborgna-q added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit 07e83a8 Mar 16, 2026
25 checks passed
@aborgna-q aborgna-q deleted the ab/release-please-draft branch March 16, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants