Skip to content

chore(devenv): update devenv and fix libiconv issue#2952

Merged
ss2165 merged 3 commits intomainfrom
ss/push-qtnptzszqrsm
Mar 17, 2026
Merged

chore(devenv): update devenv and fix libiconv issue#2952
ss2165 merged 3 commits intomainfrom
ss/push-qtnptzszqrsm

Conversation

@ss2165
Copy link
Member

@ss2165 ss2165 commented Mar 17, 2026

  • explicitly set runtime libraries on macos to avoid resolving to wrong libiconv
  • new devenv seems to set the python path incorrectly, override so the virtual env is used

@ss2165 ss2165 requested a review from aborgna-q March 17, 2026 12:19
@ss2165 ss2165 requested a review from a team as a code owner March 17, 2026 12:19
@ss2165 ss2165 requested review from ferbetanzo and removed request for aborgna-q March 17, 2026 12:19
Copy link
Contributor

@ferbetanzo ferbetanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've checked it doesn't break devenv in linux, but can't verify it in mac.

@ss2165 ss2165 enabled auto-merge March 17, 2026 12:40
@ss2165 ss2165 added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 1948767 Mar 17, 2026
25 checks passed
@ss2165 ss2165 deleted the ss/push-qtnptzszqrsm branch March 17, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants