fix: NRP-2803 circular dependencies#114
Merged
stavros-tomas merged 7 commits intomainfrom Feb 17, 2026
Merged
Conversation
ideally index.ts files should be plain barrel exports
barrel imports should not be used internally by the library
Basic ESLint config to check for cycle dependencies, we can expand later as required
aidanCQ
approved these changes
Feb 17, 2026
|
🎉 This PR is included in version 3.7.0-NRP-2803-fix-circular-dependencies.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
Author
|
Stories is outside the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Further notes
Even though JavaScript can handle cyclical dependencies relatively well, this does not mean we should ignore them, as they can lead to unexpected errors (which is why we were seeing multiple warnings about them).
Since this is a UI library, as a general rule, internal components should import other internal components directly.
Our barrel file (src/index.js) should be used only by external consumers.
It might be easier to review this PR commit by commit