Skip to content

chore: bump guppylang to 0.21.6 and cleanup DEVELOPMENT.md#90

Merged
qartik merged 6 commits intomainfrom
chore-support-py-314
Oct 31, 2025
Merged

chore: bump guppylang to 0.21.6 and cleanup DEVELOPMENT.md#90
qartik merged 6 commits intomainfrom
chore-support-py-314

Conversation

@qartik
Copy link
Member

@qartik qartik commented Oct 27, 2025

@qartik qartik marked this pull request as ready for review October 27, 2025 16:32
pyproject.toml Outdated
"tqdm>=4.67.1",
"pydot>=4.0.0",
"hugr>=0.13.0",
"hugr~=0.14.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've intentionally left the upper bound unspecified to decouple selene from guppy/hugr minor updates. Since the hugr interface used by selene is small this is pretty safe.

Guppy already has tested that selene works fine with 3.14 since it is used in the integration tests. I think that is sufficient, this PR can be simply a bump in the guppy commit used by selene tests (since the selene CI does not run any python version other than 3.10 anyway)

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest changing PR title/commit description to something like "chore: bump guppylang commit to python 3.14 compatible"

@qartik qartik changed the title chore: support Python 3.14 chore: bump guppylang commit to python 3.14 compatible Oct 27, 2025
@qartik
Copy link
Member Author

qartik commented Oct 27, 2025

Unsure if we need to wait for a guppylang release. I will let Jake or Seyon merge this.

@qartik
Copy link
Member Author

qartik commented Oct 30, 2025

@jake-arkinstall do you have an opinion on unreleased deps?

@jake-arkinstall
Copy link
Collaborator

As a test dependency, I am not fussed. It only comes to bite if the commit vanishes.

I'm primarily concerned about how it impacts guppylang's uv deps, if at all. The recursive dependency is a pain point that I would very much like to eliminate at some point. I know this has bitten a few people in the past.

@qartik
Copy link
Member Author

qartik commented Oct 30, 2025

I'm primarily concerned about how it impacts guppylang's uv deps, if at all.

Unsure if it affects that at all. Guppy is marked as a development dependency here.

If you don't foresee any issue, please merge or let me know otherwise.

@jake-arkinstall
Copy link
Collaborator

I believe for local development of guppy it gets pulled into the local workspace - could be wrong. @ss2165 what are your thoughts?

@ss2165
Copy link
Member

ss2165 commented Oct 30, 2025

yeah uv solves dev dependencies and package dependencies the same

guppylang 0.21.6 is about to be released imminently so might as well just wait for that Quantinuum/guppylang#1307

@qartik qartik requested a review from ss2165 October 31, 2025 11:30
@qartik
Copy link
Member Author

qartik commented Oct 31, 2025

I believe this is now ready for merge.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested PR/commit name:
"chore: bump guppylang to 0.21.6 and cleanup DEVELOPMENT.md"

@qartik qartik changed the title chore: bump guppylang commit to python 3.14 compatible chore: bump guppylang to 0.21.6 and cleanup DEVELOPMENT.md Oct 31, 2025
@qartik qartik merged commit fea2bac into main Oct 31, 2025
10 checks passed
@qartik qartik deleted the chore-support-py-314 branch October 31, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants