-
Notifications
You must be signed in to change notification settings - Fork 6
GraphBuilder->Graph with separate Workflow type #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 34 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
c2391c4
add some interesting functions to worker (and, update justfile)
acl-cqc 9f1bf66
tests
acl-cqc 4307b17
Merge remote-tracking branch 'origin/main' into acl/test_worker_graphs
acl-cqc 75e2a38
Hide ApplyTwiceInput
acl-cqc de7aca6
Test that GraphData is a PType
acl-cqc 692b563
Define FinishedGraph, return instead of GraphBuilder via GB.outputs(...)
acl-cqc 05a29f3
GraphBuilder: declare inputs_type
acl-cqc 1f8a6a7
FinishedGraph: frozen=True, remove get_data()
acl-cqc 4a7bd52
Rename GraphBuilder.(=>finish_with_)outputs
acl-cqc d0fbe1d
Move FinishedGraph into types.py (but keep imports via builder for now)
acl-cqc aed05b0
types.py: include FinishedGraph in PType
acl-cqc 3f47680
Remove GraphBuilder.get_data(), test worker returns FinishedGraph - v…
acl-cqc 6600e54
Test roundtrip of a FinishedGraph, given annotation; fix
acl-cqc 5794e3f
TypedGraphRef = TKR[FinishedGraph...]+reified inputs, worker funcs ta…
acl-cqc acfdfa5
fix pyright by Manually copying ApplyTwiceInput from main to stubs w/…
acl-cqc 334b5f6
Error if supposed Struct contains a TKR
acl-cqc 9c29934
Revert "Error if supposed Struct contains a TKR"
acl-cqc 66ec5c5
Better const()
acl-cqc 81db891
fmt
acl-cqc 454c18f
Advanced bodging of stub generator
acl-cqc def4fd1
Revert "Advanced bodging of stub generator"
acl-cqc be748ce
much simpler bodge
acl-cqc 3622808
be a lot stricter with asserts
acl-cqc 408ffe5
Merge remote-tracking branch 'origin/main' into acl/test_worker_graphs
acl-cqc adfd3c0
Merge remote-tracking branch 'origin/main' into acl/test_worker_graphs
acl-cqc 8c2ba50
Merge branch 'acl/test_worker_graphs' into acl/finished-graph
acl-cqc 419c026
Update ipynb's + md's, bleurgh
acl-cqc 138f028
Default GenericType to represent ptype in order to fix parsed types
acl-cqc 1543bfa
Rename FinishedGraph -> Workflow
acl-cqc deabc7a
GraphBuilder -> Graph
acl-cqc e30c5bb
Revert/reduce change to test_types.py
acl-cqc 6ccf080
Add ModelConvertible, allowing parametrized; Remove Workflow referenc…
acl-cqc 4910e5d
Visualizer: restore use of Graph
acl-cqc 76f8160
doc improvements
acl-cqc 6470fcc
Revert "Add ModelConvertible, allowing parametrized; Remove Workflow …
acl-cqc c5bb444
Move Workflow back into Models by inheriting BaseModel
acl-cqc 9224cfb
Revert "Move Workflow back into Models by inheriting BaseModel"
acl-cqc f759fa1
Merge remote-tracking branch 'origin/main' into acl/finished-graph
acl-cqc fe8b0ce
Reinstate sphinx docs on types
acl-cqc cd50b21
Move is_tmodel to models.py::is_pmodel
acl-cqc ce5daee
doc GenericType.is_ptype
acl-cqc 0ce3a34
_graph_const -> graph_const
acl-cqc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| from tierkreis.builder import GraphBuilder | ||
| from tierkreis.builder import Graph | ||
| from tierkreis.controller.data.models import TKR | ||
|
|
||
| from hello_world_worker import greet | ||
|
|
||
|
|
||
| graph = GraphBuilder(inputs_type=TKR[str], outputs_type=TKR[str]) | ||
| graph = Graph(inputs_type=TKR[str], outputs_type=TKR[str]) | ||
| hello = graph.const("Hello ") | ||
| output = graph.task(greet(greeting=hello, subject=graph.inputs)) | ||
| graph.outputs(output) | ||
| graph.finish_with_outputs(output) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entirely a vanity thing but do we want to change the module where we import this from as well? I don't think it matters too much though. Possibly we should at least re-export Graph from the root module.