feat: add methods to Subcircuit for finding const inputs#1290
Draft
acl-cqc wants to merge 2 commits intolm/new_subcircuitfrom
Draft
feat: add methods to Subcircuit for finding const inputs#1290acl-cqc wants to merge 2 commits intolm/new_subcircuitfrom
acl-cqc wants to merge 2 commits intolm/new_subcircuitfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
==========================================
- Coverage 79.46% 78.67% -0.79%
==========================================
Files 160 161 +1
Lines 20378 21364 +986
Branches 19446 20398 +952
==========================================
+ Hits 16194 16809 +615
- Misses 3201 3560 +359
- Partials 983 995 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final part of Luca's #1273, following #1288 and #1289.
I've broken these bits out because I think we should probably be doing much less here and should rely on Constant Folding to remove the conversions etc.