Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
+ Coverage 79.60% 80.06% +0.46%
==========================================
Files 160 160
Lines 20601 20610 +9
Branches 19635 19644 +9
==========================================
+ Hits 16399 16501 +102
+ Misses 3221 3139 -82
+ Partials 981 970 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1270
Fixes NormalizeGuppy to run everywhere, not just within the entrypoint (typically the entrypoint is a wrapper
mainfunction that contains no interesting quantum gates, just qalloc/discard, but calls a function outside the entrypoint that has the gates).And, fix guppy_opt.rs to run pytket everywhere. This is hard, and so this should not be test code!
Thoughts?
There's another change to behaviour on
angles.rs....