Skip to content

feat: guppy_opt everywhere#1305

Draft
acl-cqc wants to merge 14 commits intomainfrom
acl/guppy_opt_everywhere
Draft

feat: guppy_opt everywhere#1305
acl-cqc wants to merge 14 commits intomainfrom
acl/guppy_opt_everywhere

Conversation

@acl-cqc
Copy link
Contributor

@acl-cqc acl-cqc commented Dec 9, 2025

Alternative to #1270

Fixes NormalizeGuppy to run everywhere, not just within the entrypoint (typically the entrypoint is a wrapper main function that contains no interesting quantum gates, just qalloc/discard, but calls a function outside the entrypoint that has the gates).

And, fix guppy_opt.rs to run pytket everywhere. This is hard, and so this should not be test code!

Thoughts?

There's another change to behaviour on angles.rs....

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.06%. Comparing base (133c885) to head (d48a219).

Files with missing lines Patch % Lines
tket/src/passes/guppy.rs 78.57% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
+ Coverage   79.60%   80.06%   +0.46%     
==========================================
  Files         160      160              
  Lines       20601    20610       +9     
  Branches    19635    19644       +9     
==========================================
+ Hits        16399    16501     +102     
+ Misses       3221     3139      -82     
+ Partials      981      970      -11     
Flag Coverage Δ
python 92.92% <ø> (ø)
qis-compiler 100.00% <ø> (ø)
rust 79.41% <80.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant