feat!: Upgrade LLVM code in tket-qsystem and qis-compiler#1422
Open
feat!: Upgrade LLVM code in tket-qsystem and qis-compiler#1422
Conversation
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
- Coverage 79.65% 79.54% -0.11%
==========================================
Files 155 155
Lines 20335 19943 -392
Branches 19345 18953 -392
==========================================
- Hits 16197 15864 -333
+ Misses 3180 3159 -21
+ Partials 958 920 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Note that devenv.nix in this repo and the hugr repo will need to be updated to provide the newer LLVM and its path in env vars for local development. If that's already been done, ignore this - the file list is pretty huge. I'm happy to do that change otherwise. |
Author
I haven't done this, good catch. I'd appreciate if you make the change - better if it's tested by a devenv user anyway. |
cqc-alec
reviewed
Mar 2, 2026
Cargo.lock
Outdated
| version = "0.25.6" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "b6baee3cc2fe4d7c5635a630341e28237f12a8e5beef31b5aaaebe93bc9ba90a" | ||
| source = "git+https://github.com/quantinuum/hugr?branch=george%2Fllvmup#7d8587c64086ea5a2a4486b23ef7b73ab2c44040" |
Collaborator
There was a problem hiding this comment.
I'm not sure that we want to be depending on these branches from main here. Should we wait for an updated release of hugr?
Author
There was a problem hiding this comment.
Yes, my plan is to release hugr first and change these to point to the release before merging.
Author
There was a problem hiding this comment.
But I hope to merge the HUGR PR + this PR + the internal PR in quick succession, hence putting them up for review together.
Collaborator
|
Have given it a superficial review (and ignored all the snaps assuming those changes make sense). LGTM! |
and update the path for ComposablePass imports.
Author
|
@aborgna-q This should be ready for you to merge into the release branch. Notes:
Still a few bugs. In particular, the one about failure to monomorphize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The hugr-llvm LLVM version is being upgraded to 21.1, and code that depends on it here needs to be updated as well. This also includes an MSRV change to 1.91 to match hugr. See the hugr PR for details.
Closes #1421