feat!: Follow pass scopes in composable passes#1429
Draft
aborgna-q wants to merge 5 commits intoab/hugr-0.26.0from
Draft
feat!: Follow pass scopes in composable passes#1429aborgna-q wants to merge 5 commits intoab/hugr-0.26.0from
aborgna-q wants to merge 5 commits intoab/hugr-0.26.0from
Conversation
3 tasks
aborgna-q
force-pushed
the
ab/pass-scopes
branch
from
a337a40 to
6119e18
Compare
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
==========================================
- Coverage 79.59% 79.53% -0.07%
==========================================
Files 157 157
Lines 20465 20463 -2
Branches 19476 19474 -2
==========================================
- Hits 16290 16276 -14
- Misses 3193 3208 +15
+ Partials 982 979 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aborgna-q
force-pushed
the
ab/pass-scopes
branch
from
ca4ba4b to
8620e7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
PassScopes in the pass definitions. See Quantinuum/hugr#2772.Requires a hugr release with the
PassScopedefinition and Quantinuum/hugr#2910.Many of these also call other passes from
hugr_passes. While we pass the scope config along, proper support requires Quantinuum/hugr#2836 and Quantinuum/hugr#2871.This is a rust-only change, the python interface will follow up.
BREAKING CHANGE: Multiple unit-like pass structs must now be constructed using a
::default()call instead.