fix(pytket decoder): Panic on repeated registers in pytket decoded output#1445
Open
fix(pytket decoder): Panic on repeated registers in pytket decoded output#1445
Conversation
aborgna-q
commented
Mar 13, 2026
Comment on lines
+321
to
+322
| let mut qubits: Vec<TrackedQubit> = Vec::new(); | ||
| let mut bits: Vec<TrackedBit> = Vec::new(); |
Collaborator
Author
There was a problem hiding this comment.
This is the main fix.
We populated this with the registers declared at the Hugr output.
If the output said e.g. b[0], b[0], b[1] we ignored the second entry, and ended up outputting b[0], b[1], new_allocated_bit
aborgna-q
commented
Mar 13, 2026
| node, | ||
| hugr, | ||
| // Output bits use new registers, so don't reuse any input bits. | ||
| EmitCommandOptions::new().reuse_bits(|_| vec![]), |
Collaborator
Author
There was a problem hiding this comment.
Drive-by: The classical expression emitter was re-using the input bits to the node instead of using a separate output bit register.
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
+ Coverage 79.65% 80.01% +0.36%
==========================================
Files 155 155
Lines 20335 20333 -2
Branches 19345 19343 -2
==========================================
+ Hits 16197 16270 +73
+ Misses 3180 3101 -79
- Partials 958 962 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an edge case where we extracted a hugr from a pytket circuit, and declared multiple output ports to have the same bit register.
Also cleans up a bit of the logic that handled consumed bit wires, to avoid marking them as outdated if they can still be used by other operations.